[gstreamer-bugs] [Bug 535656] [equalizer] Static in Banshee even with eq checkbox disabled

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=535656

  GStreamer | gst-plugins-good | Ver: 0.10.8

Sebastian Dröge changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|gstreamer-                  |slomo at circular-chaos.org
                   |bugs at lists.sourceforge.net  |
             Status|UNCONFIRMED                 |NEEDINFO




------- Comment #4 from Sebastian Dröge  2008-05-31 08:38 UTC -------
Ok, with these two changes I see no way how the current equalizer could produce
corrupted output anymore... please confirm that it works fine with latest CVS
(you should be able to build latest CVS of the equalizer with core/base
0.10.18, if you need x86 binaries just ask me).

2008-05-31  Sebastian Dröge  <slomo at circular-chaos.org>

        * gst/equalizer/gstiirequalizer.c:
        (gst_iir_equalizer_transform_ip):
        Don't clip float/double samples, correctly unset passthrough mode
        and use better rounding for integer samples.

2008-05-30  Sebastian Dröge  <slomo at circular-chaos.org>

        * gst/equalizer/gstiirequalizer.c:
        (gst_iir_equalizer_band_set_property), (gst_iir_equalizer_init),
        (setup_filter), (set_passthrough), (update_coefficients),
        (gst_iir_equalizer_compute_frequencies),
        (gst_iir_equalizer_transform_ip):
        * gst/equalizer/gstiirequalizer.h:
        Update the filter coefficients only when needed in the transform_ip
        function and correctly set the element into passthrough mode if the
        gain of all bands is 0.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=535656.