[gstreamer-bugs] [Bug 555699] New: [PATCH] theoradec: prefer container's pixel aspect ratio over the stream's

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=555699

  GStreamer | gst-plugins-base | Ver: HEAD CVS
           Summary: [PATCH] theoradec: prefer container's pixel aspect ratio
                    over the stream's
           Product: GStreamer
           Version: HEAD CVS
          Platform: Other
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-plugins-base
        AssignedTo: gstreamer-bugs at lists.sourceforge.net
        ReportedBy: robin at nibor.org
         QAContact: gstreamer-bugs at lists.sourceforge.net
     GNOME version: Unspecified
   GNOME milestone: Unspecified


When a Theora video stream is inside the Matroska container and a
pixel-aspect-ratio is specified in the container, it is not respected. Instead,
theoradec overwrites the PAR with the values the stream itself provides. But
the PAR of the container should take precedence over what the stream says
because a user usually sets it with the container.

The attached patch (against HEAD) uses the PAR provided by the container if
there is one and falls back to the one from the stream itself if not. Note that
the patch is kind of a proof of concept, the comment around that code should
also be changed and I'm not sure if the unref is right.

I noticed that behaviour because Totem with the GStreamer backend seemed to
ignore Matroska's display-dimensions. And it's not just with Theora streams,
MPEG streams for example also have that problem. Is changing the decoders like
in the patch the right way to solve this? If yes, I can look at the other
decoders and try to come up with patches.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=555699.