[gstreamer-bugs] [Bug 527951] [new element] aspectratiocrop

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=527951

  GStreamer | gst-plugins-good | Ver: HEAD CVS




------- Comment #5 from Thijs Vermeir  2008-10-09 23:00 UTC -------
(In reply to comment #4)
> I was going to ask you to document that this element cropped to a specifed
> display aspect ratio... but then I looked at the code, and it doesn't - it
> crops to a specified image aspect ratio.
> 
> Is this actually what anyone wants? It seems unlikely. Please make it crop to
> the specified DAR instead, unless you can explain why doing what it currently
> does is sensible.

No, I'm really talking about (image) aspect ratio here. I'm using this in a
transcoding pipeline with sources from TV, DVD and internet, where it is not
uncommen that they add (by mistake or incopetence) black borders. But ofcourse
it doesn't make sence to transcode these black borders. So here it has nothing
todo with DAR but I think this is still a usefull element. Cropping to DAR can
also be usefull but it's not the goal here...

And I'm happy that you review in such de
> 
> Also, please rename incomming_ar to incoming_ar - it'll annoy me less! :-)
> 

I'm happy that you review in such detail, will fix it ;)


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=527951.