[gstreamer-bugs] [Bug 556066] Last byte of FLAC image buffer chopped off

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=556066

  GStreamer | gst-plugins-base | Ver: HEAD CVS

Sebastian Dröge changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |NEEDINFO




------- Comment #4 from Sebastian Dröge  2008-10-14 11:13 UTC -------
Hm, I don't get it, sorry :)

First we allocate the buffer with image_data_len + 1, set the last, additional
byte to \0 and then typefind. Afterwards we look at the typefinding result and
unless it's an URI list we make the buffer size one smaller (resulting in the
\0 being outside of the buffer).

Before the problem was, that we allocate the buffer with image_data_len + 1
bytes, set the buffer size immediately to image_data_len and pass this to
typefinding and later make the buffer size one less if we don't have an URI
list. This then results in image_data_len as size of URI lists and
image_data_len-1 for others, i.e. one byte less than it should be for
everything.

Am I missing something?


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=556066.