[gstreamer-bugs] [Bug 550791] [flacenc] files are too big, mid-side-stereo=true should be the default

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=550791

  GStreamer | gst-plugins-good | Ver: HEAD CVS

Tim-Philipp Müller changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |t.i.m at zen.co.uk
           Severity|enhancement                 |minor
             Status|UNCONFIRMED                 |RESOLVED
          Component|gst-plugins                 |gst-plugins-good
         Resolution|                            |FIXED
            Summary|flac encoded by gstreamer   |[flacenc] files are too big,
                   |are too big, mid-side-      |mid-side-stereo=true should
                   |stereo=true should be the   |be the default
                   |default                     |
   Target Milestone|HEAD                        |0.10.11
            Version|0.10.18                     |HEAD CVS




------- Comment #1 from Tim-Philipp Müller  2008-09-04 09:27 UTC -------
Oops, nice catch. In fact mid-side-stereo should even be set to true by
default, but isn't. Should be fixed in CVS now:

 2008-09-04  Tim-Philipp Müller  <tim.muller at collabora co uk>

        * ext/flac/gstflacenc.c: (gst_flac_enc_class_init):
          Make sure the desired default values are actually set, not only
          registered as defaults (actual problem is that the stereo-specific
          values are only updated if channels==2, which is not the case yet
          when the object is created, so the default values for the
          mid-side-stereo and loose-mid-side-stereo settings are never
          set in _update_quality()). Makes flacenc create smaller files by
          default (for stereo input), and fixes #550791.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=550791.