[gstreamer-bugs] [Bug 368536] bin_change_state makes children go through unnecessary state changes

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=368536

  GStreamer | gstreamer (core) | Ver: HEAD CVS

Antoine Tremblay changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75738|0                           |1
        is obsolete|                            |
  Attachment #76101|0                           |1
        is obsolete|                            |
 Attachment #118386|0                           |1
        is obsolete|                            |




------- Comment #10 from Antoine Tremblay  2008-09-24 21:55 UTC -------
Created an attachment (id=119337)
 --> (http://bugzilla.gnome.org/attachment.cgi?id=119337&action=view)
Updated patch fixed ASYNC changes bug

My previous condition to check if we should skip was a stupid mistake :( ..
don't know how I could do this.. sorry :(

now I only allow skipping a state if there is not pending states for the
element
so it should be ok with ASYNC state changes...

   if(child_pending != GST_STATE_VOID_PENDING ||
            (child_pending == GST_STATE_VOID_PENDING &&
                ((pending > child_current && next > child_current) ||
                    (pending < child_current && next < child_current ))))

Please review...


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=368536.