[gstreamer-bugs] [Bug 577843] input-selector causes problems with DVD menus in playbin2

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=577843

  GStreamer | gst-plugins-bad | Ver: git




------- Comment #6 from Michael Smith  2009-04-22 17:51 UTC -------
Your patch doesn't look right to me - it still results in an update=FALSE
segment being sent when it receives an update=TRUE segment. Why is it doing it
that way?

My case is specifically that update=TRUE new segment events MUST be forwarded
as update=TRUE. 

(I only really tested with single-stream audio files - so the selector isn't
actually doing any meaningful selecting) 

Details:
 - using playbin2
 - some element sends a closed (i.e. has valid start AND stop) new-segment
event.
 - later, said element decides it didn't actually want that segment to have a
valid stop time. So it sends an update-new-segment that is the same as the
original one, but with stop=GST_CLOCK_TIME_NONE
 - current input-selector forwards this as a new, update=FALSE, new-segment -
so the old segment with the incorrect stop time is still used.
 - my patch makes it preserve the update flag

Something like your patch might be needed too - I think we're actually seeing
different problems with vaguely-related underlying causes, and we need to fix
both things. I'm not entirely convinced that I understand new-segment semantics
(particular for sparse streams) well enough to fix this properly.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=577843.