[gstreamer-bugs] [Bug 577843] input-selector causes problems with DVD menus in playbin2

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=577843

  GStreamer | gst-plugins-bad | Ver: git

Michael Smith changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #133120|none                        |needs-work
               Flag|                            |




------- Comment #8 from Michael Smith  2009-04-22 18:25 UTC -------
Ah, I did misread your patch - I think your general approach makes sense. Also,
in a quick test, your patch seems to work for my testcase.

However, I still don't get how your patch accomplishes _your_ goals.
(below, line numbers are in the file with your patch applied):

 1. gstinputselector:353: we activate the pad we receive _any_ event on, if
there's no active pad.
 2. gstinputselector:398: so now, your if (update && sel->active_sinkpad ==
NULL) is always false because active_sinkpad can't be NULL, so that new code is
never used.

Also, if we hadn't already activated the sinkpad in (1), we wouldn't forward
the event: we would have set forward = FALSE at line 358. 

So... conceptually this looks fine, but needs some fixes? Unless I'm still
missing something?


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=577843.