[gstreamer-bugs] [Bug 590860] New: Incorrect scrambling info processing

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=590860

  GStreamer | gst-plugins-bad | Ver: 0.10.13
           Summary: Incorrect scrambling info processing
           Product: GStreamer
           Version: 0.10.13
          Platform: Other
        OS/Version: All
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-plugins-bad
        AssignedTo: gstreamer-bugs at lists.sourceforge.net
        ReportedBy: ivan.murashko at gmail.com
         QAContact: gstreamer-bugs at lists.sourceforge.net
     GNOME version: Unspecified
   GNOME milestone: Unspecified


Please describe the problem:
The mpegtsparse plug-in determines scrambling control incorrectly. The attached
patch resolved the problem in my case

As I understood the problem is that the code
tmp = GST_READ_UINT16_BE (data); 
changes the byte order and scrambling control is read from data[1] instead of
data[0]



Steps to reproduce:
In my case a have a scan utility based on mpegtsparse plugin and I compare its
result with result with scan utility from dvb-apps package
(http://ftp.osuosl.org/pub/nslu2/sources/DVB-20050311.tar.gz)


Actual results:


Expected results:


Does this happen every time?
sometimes

Other information:
less scrambling.patch 
*** distr/gst-plugins-bad-0.10.13/gst/mpegdemux/mpegtspacketizer.c     
2009-05-12 01:18:14.000000000 +0400
--- distr/gst-plugins-bad-0.10.13/gst/mpegdemux/mpegtspacketizer_fix.c 
2009-08-05 18:14:01.000000000 +0400
***************
*** 1273,1279 ****
      EIT_schedule = (tmp >> 15);
      EIT_present_following = (tmp >> 14) & 0x01;
      running_status = (tmp >> 5) & 0x03;
!     scrambled = (tmp >> 4) & 0x01;
      descriptors_loop_length = tmp & 0x0FFF;

      /* TODO send tag event down relevant pad for channel name and provider */
--- 1273,1279 ----
      EIT_schedule = (tmp >> 15);
      EIT_present_following = (tmp >> 14) & 0x01;
      running_status = (tmp >> 5) & 0x03;
!     scrambled = (entry_begin[3] >> 4) & 0x01;
      descriptors_loop_length = tmp & 0x0FFF;

      /* TODO send tag event down relevant pad for channel name and provider */
scrambling.patch (END)


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=590860.