[gstreamer-bugs] [Bug 590942] New: avoid recalculating caps in basetransform

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=590942

  GStreamer | gstreamer (core) | Ver: git
           Summary: avoid recalculating caps in basetransform
           Product: GStreamer
           Version: git
          Platform: Other
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: enhancement
          Priority: Normal
         Component: gstreamer (core)
        AssignedTo: gstreamer-bugs at lists.sourceforge.net
        ReportedBy: ensonic at sonicpulse.de
         QAContact: gstreamer-bugs at lists.sourceforge.net
     GNOME version: Unspecified
   GNOME milestone: Unspecified


gst_base_transform_getcaps is called quite often and even with same parameters.
It would be nice if we can avoid rerunning all the calculations in those cases.

Templatecaps don't change. If we can assume that _transform_caps() only depends
on its inputs, we can cache results and avoid recalculation intersects.

The attached patch does that. I don't see regressions from unit-tests, nor from
totem, rythmbox, buzztard, pitivi and jokosher. Is it safe to do this?


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=590942.