[gstreamer-bugs] [Bug 588148] [id3demux] APIC tag not found mp3 file

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=588148

  GStreamer | gst-plugins-good | Ver: 0.10.15

Tim-Philipp Müller changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138201|none                        |rejected
               Flag|                            |
         AssignedTo|t.i.m at zen.co.uk             |gstreamer-
                   |                            |bugs at lists.sourceforge.net
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|HEAD                        |0.10.16




------- Comment #5 from Tim-Philipp Müller  2009-08-07 15:58 UTC -------
This should fix it:

 commit 2e05af387614b9850a9b0782e5ee1ab1a78362fd
 Author: Tim-Philipp Müller <tim.muller at collabora.co.uk>
 Date:   Fri Aug 7 16:02:23 2009 +0100

    id3demux: fix parsing of unsync'ed ID3 v2.4 tags and frames

    Reversing the unsynchronisation seems to work slightly differently
    for ID3 v2.3 tags and v2.4 tags: v2.3 tags don't have syncsafe frame
    sizes in the frame header, so the unsynchronisation is applied to
    the whole frame data including all the frame headers. v2.4 frames
    have sync-safe sizes, however, so the unsynchronisation only needs
    to be applied to the actual frame data, and it seems that's what's
    being done as well. So we need to undo the unsynchronisation on a
    per-frame basis for v2.4 tags for things to work properly.

    Fixes extraction of coverart/images from APIC frames in ID3 v2.4
    tags (#588148).

    Add unit test for this as well.


Sorry it took so long. Was pretty busy with other stuff.

(Your patch would've broken parsing of unsynced v2.3 tags IIRC.)


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=588148.