[gstreamer-bugs] [Bug 591651] New: [dvbsrc] Should use better nicks for GstDvbSrcModulation enum

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=591651

  GStreamer | gst-plugins-bad | Ver: git
           Summary: [dvbsrc] Should use better nicks for GstDvbSrcModulation
                    enum
           Product: GStreamer
           Version: git
          Platform: Other
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-plugins-bad
        AssignedTo: gstreamer-bugs at lists.sourceforge.net
        ReportedBy: slomo at circular-chaos.org
         QAContact: gstreamer-bugs at lists.sourceforge.net
     GNOME version: Unspecified
   GNOME milestone: Unspecified


Hi,
currently it is like this:
  static GEnumValue modulation_types[] = {
    {QPSK, "QPSK", "QPSK"},
    {QAM_16, "QAM 16", "QAM 16"},
    {QAM_32, "QAM 32", "QAM 32"},
    {QAM_64, "QAM 64", "QAM 64"},
    {QAM_128, "QAM 128", "QAM 128"},
    {QAM_256, "QAM 256", "QAM 256"},
    {QAM_AUTO, "AUTO", "AUTO"},
    {VSB_8, "8VSB", "8VSB"},
    {VSB_16, "16VSB", "16VSB"},
    {0, NULL, NULL},
  };

It should be more like:
  static GEnumValue modulation_types[] = {
    {QPSK, "QPSK", "QPSK"},
    {QAM_16, "QAM 16", "QAM-16"},
    {QAM_32, "QAM 32", "QAM-32"},
    {QAM_64, "QAM 64", "QAM-64"},
    {QAM_128, "QAM 128", "QAM-128"},
    {QAM_256, "QAM 256", "QAM-256"},
    {QAM_AUTO, "AUTO", "AUTO"},
    {VSB_8, "8VSB", "8-VSB"},
    {VSB_16, "16VSB", "16-VSB"},
    {0, NULL, NULL},
  };

Enum nicks usually contain no spaces and are usually all lowercase as well.
Every other element I'm aware of uses the same rules as the rules that apply
for property nicks.

Problem with spaces is especially when using gst-launch, you need to use
modulation="QAM 16" instead of something like modulation=qam-16  (note the "")

Would be nice to change this here before it gets moved to -good :)


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=591651.