[gstreamer-bugs] [Bug 586570] Add GAP Flag support to audioresample

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=586570
  GStreamer | gst-plugins-base | git

--- Comment #9 from Chad <channa at caltech.edu> 2009-12-01 19:59:47 UTC ---
(In reply to comment #5)
> I'm not 100% conviced by this patch ;)
> 
> You're setting the output to zeroes if the gap can be skipped but the resampler
> internal filter line will still have the old input data. Won't this result in
> suboptimal output if processing continues because it doesn't interpolate from
> silence but from the older input data?

I think this is an interesting point.  To me it isn't clear what the right
thing to do is.  If a user's pipeline previously memsets the gaps to zero, then
it is not a problem.  If they do not, then perhaps the desired behavior is to
use what was in the gap.  It may contain the correct information for the
resampler to use.  In our application it does.  What do you think?   


> Then you drain the resampler. Draining the resampler will result in suboptimal
> output in the last few samples. Is this important here or will these last few
> samples always be silence (from the GAP buffer)?
> 
> And then I wonder if draining the resampler and then continue using it later
> won't introduce additional latency.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.