[gstreamer-bugs] [Bug 601617] matroska-demuxer triggers an assert in gststructure.c

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Thu Dec 3 01:04:30 PST 2009


https://bugzilla.gnome.org/show_bug.cgi?id=601617
  GStreamer | gst-plugins-good | unspecified

--- Comment #7 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2009-12-03 09:04:26 UTC ---
Created an attachment (id=148988)
 View: https://bugzilla.gnome.org/attachment.cgi?id=148988
 Review: https://bugzilla.gnome.org/review?bug=601617&attachment=148988

matroskademux: only send pending tags with newsegment events

> gst_matroska_demux_send_event () is not thread safe at the moment.
> BTW, Does it make sense to send the pending tags with 'flush-start' and
> 'newsegment'? Isn't that supposed to be done only for the new tag events?

No, you're quite right. They should not be sent with flush-start/flush-stop,
only after a newsegment event. Nice catch!

Does the attached patch make things work?

Btw, if you issue a seek that early (ie. you don't wait for preroll), chances
are it will fail. Might be a bit racy.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.



More information about the Gstreamer-bugs mailing list