[gstreamer-bugs] [Bug 597822] Add removesilence plugin

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=597822
  GStreamer | gst-plugins-bad | git

--- Comment #6 from tiagokatcipis at gmail.com 2009-12-30 22:14:08 UTC ---
>> this looks a bit different in gstreamer files usually

Well i can fix that to make more "Gstreamer like" :-).


>> not critical fro getting it in, but supporting more formats natively would be
>> nice (e.g. width/depth). Also do you have any thoughts on how this would work
>> with e.g. stereo or more channels?

The VAD code is pretty simple and only works with this width and depth, the
only thing that is flexible is the samplerate. The VAD only works with one
channel. Since the main application is to remove silence from phone calls i did
not care with stereo or more channels, neither with the depth and width, but if
someone thinks on a good way to implement it, it would be good :-).


>> Don't you need to reset this during state changes (e.g. to make it work if >>the
>> element is used a 2nd time)?

Well i am already using it on a product and it is working as it is... but I'm
really newbie at Gstreamer, if you think it must be reset on state change i can
implement it with no problem, but i cant say for sure if it is really needed.


>> The macro should be called GST_REMOVE_SILENCE.

This one i can fix :-).

>> wouldn't it make sense to have some of those as gobject properties?

Since the VAD code was not developed by me i didn't changed this values, but i
suppose some of them can be configured, like the hysteresis.

well I'm going to perform some of this changes and send a new patch here.

Thanks for the help Stefan.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.