[gstreamer-bugs] [Bug 570910] Removing the target of a ghostpad does not re-target the ghostpad to NULL

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=570910

  GStreamer | gstreamer (core) | Ver: git




------- Comment #3 from Michael Smith  2009-02-09 19:31 UTC -------
Created an attachment (id=128319)
 --> (http://bugzilla.gnome.org/attachment.cgi?id=128319&action=view)
Fixed version of david's patch

This fixes up the refcounting in David's patch.

It then changes one of the exiting ghostpad tests - which was explicitly
checking that a ref was retained in this case. I think the test is wrong.

This seems inelegant - my thought it that we should be able to fix it in
gstghostpad.c, rather than changing how gstbin removes elements. However, my
attempt at doing so ended up in deadlocks. Advice from someone who understands
the current ghostpad implementation properly would be very welcome.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=570910.