[gstreamer-bugs] [Bug 571146] New: [mpeg2dec] Probably uses wrong strides for 4:2:2 and 4:4:4 YUV

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=571146

  GStreamer | gst-plugins-ugly | Ver: 0.10.x
           Summary: [mpeg2dec] Probably uses wrong strides for 4:2:2 and
                    4:4:4 YUV
           Product: GStreamer
           Version: 0.10.x
          Platform: Other
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: blocker
          Priority: Normal
         Component: gst-plugins-ugly
        AssignedTo: gstreamer-bugs at lists.sourceforge.net
        ReportedBy: slomo at circular-chaos.org
         QAContact: gstreamer-bugs at lists.sourceforge.net
     GNOME version: Unspecified
   GNOME milestone: Unspecified


Hi,
mpeg2dec probably uses wrong strides for 4:2:2 and 4:4:4 YUV:

4:2:2:
    halfsize = mpeg2dec->decoded_width * mpeg2dec->decoded_height;
    mpeg2dec->size = halfsize * 2;
    mpeg2dec->u_offs = halfsize;
    mpeg2dec->v_offs = halfsize + (halfsize / 2);

4:4:4:
    size = mpeg2dec->decoded_width * mpeg2dec->decoded_height;

    mpeg2dec->size = size * 3;
    mpeg2dec->u_offs = size;
    mpeg2dec->v_offs = size * 2;

We usually have the strides rounded up to the next integer multiply of 4 bytes
and videotestsrc/ffmpegcolorspace are doing this too. Is there any reason why
the above code is still correct, like size always being an integer multiply of
4?


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=571146.