[gstreamer-bugs] [Bug 572285] Buffer Array

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=572285

  GStreamer | gstreamer (core) | Ver: git

Sebastian Dröge changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |slomo at circular-chaos.org




------- Comment #3 from Sebastian Dröge  2009-02-18 16:36 UTC -------
<slomo> jij: looks like it could cause alignment problems... you store the
length as guint before the array of GstBufferArrayData, if
sizeof(guint)!=sizeof(gpointer) you store a pointer (data field of
GstBufferArrayData) not pointer aligned
<jij> slomo, darn, I knew that would cause some problem
<slomo> jij: look at libgstfft and grep for STRUCT_ALIGN or ALIGN_STRUCT
<jij> slomo, why didn't someone add a size field for the free func in GstBuffer
:)
<jij> slomo, thx
<slomo> jij: essentially you have to allocate 2*sizeof(size_t) for the size
field and put the array afterwards
<jij> slomo, ok




Also it would make sense to use GstMiniObject as base class here, it would give
you refcounting and all that.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=572285.