[gstreamer-bugs] [Bug 571153] [pulsemixer] compiler warnings (on ARM)

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=571153

  GStreamer | gst-plugins-good | Ver: git

Sebastian Dröge changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|0.10.14                     |0.10.15




------- Comment #9 from Sebastian Dröge  2009-02-22 17:26 UTC -------
commit dfa627da30dd44e170f3249ff3bdda333ea1edf1
Author: Sebastian Dröge <sebastian.droege at collabora.co.uk>
Date:   Sun Feb 22 18:08:59 2009 +0100

    pulsemixer: Don't use g_atomic_int_(get|set) for accessing the mixer track
f

    g_atomic_int_(get|set) only work on ints and the flags are
    an enum (which on most architectures is stored as an int).

    Also the way the flags were accessed atomically would still
    leave a possible race condition and we don't do it in any
    other mixer track implementation, let alone at any other
    place where an integer could be changed from different
    threads. Removing the g_atomic_int_(get|set) will only
    introduce a new race condition on architectures where
    integers could be half-written while reading them
    which shouldn't be the case for any modern architecture
    and if we really care about this we need to use
    g_atomic_int_(get|set) at many other places too.

    Apart from that g_atomic_int_(set|get) will result in
    aliasing warnings if their argument is explicitely
    casted to an int *. Fixes bug #571153.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=571153.