[gstreamer-bugs] [Bug 573370] New: camerabin api improvements

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=573370

  GStreamer | gst-plugins-bad | Ver: git
           Summary: camerabin api improvements
           Product: GStreamer
           Version: git
          Platform: Other
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: enhancement
          Priority: Normal
         Component: gst-plugins-bad
        AssignedTo: gstreamer-bugs at lists.sourceforge.net
        ReportedBy: ensonic at sonicpulse.de
         QAContact: gstreamer-bugs at lists.sourceforge.net
     GNOME version: Unspecified
   GNOME milestone: Unspecified


Camerabin uses a signal callback with thsi signature for "img-done" signal
gboolean img_done (GstElement * elem, GString * filename, gpointer user_data)

The user is supposed to modify the passed GString * filename. This is bad for
two reasons:
#1: camerabin has a filename property and chaging that from within the callback
won't show any effect
#2: its not visible from the docs that the filename parameter is a GString* as
there is no type for the signal marshallers for it.
#3: not using g_object_set, break notify:filename

Proposal is to change the filename parameter to to "char *" and get rid of the
GString totally.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=573370.