[gstreamer-bugs] [Bug 572993] Broken libregex dependency on Windows

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=572993

  GStreamer | gst-plugins-base | Ver: git




------- Comment #2 from David Schleef  2009-02-28 05:29 UTC -------
Only the return value of g_regex_new() needs to be tested for NULL:

- if (mdvd_grx == NULL || gerr != NULL) {
+ if (mdvd_grx == NULL) {

The GST_WARNINGs should be g_warning()s.

As a side note, the creation of regexes here is not thread-safe, but it is
unsafe without the patch too.  I'd like to see this code fixed to use GOnce. 
If you want to fix it, go ahead, otherwise just mark it /* FIXME thread unsafe,
should use GOnce */.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=572993.