[gstreamer-bugs] [Bug 567794] [PATCH] Rework pulse plugin

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=567794

  GStreamer | gst-plugins-good | Ver: 0.10.11

Jan Schmidt changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |thaytan at mad.scientist.com




------- Comment #2 from Jan Schmidt  2009-01-14 22:55 UTC -------
This patch is using API and constants that didn't exist in the pulseaudio I
have - 0.9.10.

Applying it would make the pulse plugin unusable on Intrepid (and what other
distros?), which seems like a pretty bad idea.

here's some compile log:

pulsesink.c: In function ‘gst_pulsesink_init’:
pulsesink.c:266: error: implicit declaration of function
‘pa_sample_spec_init’
pulsesink.c: In function ‘gst_pulsesink_sink_input_info_cb’:
pulsesink.c:390: error: implicit declaration of function ‘pa_cvolume_max’
pulsesink.c: In function ‘gst_pulsesink_is_dead’:
pulsesink.c:395: error: implicit declaration of function
‘PA_CONTEXT_IS_GOOD’
pulsesink.c:396: error: implicit declaration of function
‘PA_STREAM_IS_GOOD’
pulsesink.c: In function ‘gst_pulsesink_prepare’:
pulsesink.c:787: error: ‘PA_STREAM_ADJUST_LATENCY’ undeclared (first use in
this function)
pulsesink.c:787: error: (Each undeclared identifier is reported only once
pulsesink.c:787: error: for each function it appears in.)
pulsesink.c: In function ‘gst_pulsesink_change_props’:
pulsesink.c:1035: error: ‘PA_PROP_MEDIA_TITLE’ undeclared (first use in
this function)
pulsesink.c:1036: error: ‘PA_PROP_MEDIA_ARTIST’ undeclared (first use in
this function)
pulsesink.c:1037: error: ‘PA_PROP_MEDIA_LANGUAGE’ undeclared (first use in
this function)
pulsesink.c:1038: error: ‘PA_PROP_MEDIA_FILENAME’ undeclared (first use in
this function)
pulsesink.c:1043: error: ‘pa_proplist’ undeclared (first use in this
function)
pulsesink.c:1043: error: ‘pl’ undeclared (first use in this function)
pulsesink.c:1043: error: invalid operands to binary * (have ‘const gchar *
const*’ and ‘const gchar * const*’)
pulsesink.c:1043: error: statement with no effect
pulsesink.c:1044: error: ISO C90 forbids mixed declarations and code
pulsesink.c:1048: error: implicit declaration of function ‘pa_proplist_new’
pulsesink.c:1048: error: statement with no effect
pulsesink.c:1056: error: implicit declaration of function
‘pa_proplist_sets’
pulsesink.c:1072: error: implicit declaration of function
‘pa_stream_proplist_update’
pulsesink.c:1072: error: ‘PA_UPDATE_REPLACE’ undeclared (first use in this
function)
pulsesink.c:1072: error: assignment makes pointer from integer without a cast
pulsesink.c:1091: error: implicit declaration of function
‘pa_proplist_free’

If you know what version the various API was introduced in, perhaps we can add
some defines to only use things when they're available?


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=567794.