[gstreamer-bugs] [Bug 562170] GstBus watch doesn't work with non-default main context

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=562170

  GStreamer | gstreamer (core) | Ver: 0.10.21




------- Comment #8 from Tim-Philipp Müller  2009-01-16 19:52 UTC -------
Created an attachment (id=126601)
 --> (http://bugzilla.gnome.org/attachment.cgi?id=126601&action=view)
Patch fixing GstBusSource inheritance and unit test which fails w/o this patch

Rookie mistake: GstBusSource didn't inherit from GSource directly, which
overwrites bussource->inited when GLib initialises what it thinks is the
GSource member at the very beginning of the struct. This leads to non-default
main contexts not working in some or all circumstances (no idea why it's not
triggered with the existing unit test).

This should most likely go into the release, even though I don't think it
actually causes bad memory access of any kind.

Patch also contains a unit test which demonstrates the bug (hangs until timeout
because the custom context is never woken up when the eos message is posted on
the bus, because it's not set, which is because bsrc->inited is already
non-zero as described above).


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=562170.