[gstreamer-bugs] [Bug 568678] New: filesrc doesn't logs offsets

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=568678

  GStreamer | gstreamer (core) | Ver: git
           Summary: filesrc doesn't logs offsets
           Product: GStreamer
           Version: git
          Platform: Other
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gstreamer (core)
        AssignedTo: gstreamer-bugs at lists.sourceforge.net
        ReportedBy: pancake at youterm.com
         QAContact: gstreamer-bugs at lists.sourceforge.net
     GNOME version: Unspecified
   GNOME milestone: Unspecified


The filesrc element only logs the length of the reads, but not the offset
address.

This patch adds this information to the GST_DEBUG line:

diff --git a/plugins/elements/gstfilesrc.c b/plugins/elements/gstfilesrc.c
index 964b605..db60212 100644
--- a/plugins/elements/gstfilesrc.c
+++ b/plugins/elements/gstfilesrc.c
@@ -830,7 +830,7 @@ gst_file_src_create_read (GstFileSrc * src, guint64 offset,
guint length,
     return GST_FLOW_ERROR;
   }

-  GST_LOG_OBJECT (src, "Reading %d bytes", length);
+  GST_LOG_OBJECT (src, "Reading %d bytes at 0x"G_GUINT64_FORMAT" offset",
length, offset);
   ret = read (src->fd, GST_BUFFER_DATA (buf), length);
   if (G_UNLIKELY (ret < 0))
     goto could_not_read;


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=568678.