[gstreamer-bugs] [Bug 569682] playbin2 leaks request pad from input selector

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=569682

  GStreamer | gst-plugins-base | Ver: git

Michael Smith changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|HEAD                        |0.10.23




------- Comment #2 from Michael Smith  2009-01-31 02:33 UTC -------
Fixed all the leaks I could find with this command and simple gapless playback
of 2 or 3 files using test7.

Pushed the following to git:

gst-plugins-bad: 
commit 6a0a9fc01e2aec4020b8f35b4a4ce5df8e60e9d7
Author: Michael Smith <msmith at songbirdnest.com>
Date:   Fri Jan 30 18:27:03 2009 -0800

    Unref event if we don't forward it, unref pads when done with them.


gst-plugins-base: 
commit b36d8f3e119f9edc5993c08025614ee32642972e
Author: Michael Smith <msmith at songbirdnest.com>
Date:   Fri Jan 30 17:48:23 2009 -0800

    Remove pad-removed handlers after setting the decodebins to NULL.

    They do needed cleanup; without this we leak selector requestpads.

commit 61e81ada2c9eb5d4bfb12e4e2997be790650ced3
Author: Michael Smith <msmith at songbirdnest.com>
Date:   Fri Jan 30 17:47:07 2009 -0800

    Unref selector request pad even if we no longer have a selector.

    During destruction, we won't have a selector any more, but we still need
    to unref the pad to avoid leaking it.

commit c799f3f77f7a06d6a7c02e03d9d2d86610a94134
Author: Michael Smith <msmith at songbirdnest.com>
Date:   Fri Jan 30 15:23:23 2009 -0800

    Unref source in playbin2's finalize method

commit b6cbe7e3315d49313b7e7098f27dc0a895e96dc1
Author: Michael Smith <msmith at songbirdnest.com>
Date:   Fri Jan 30 12:04:01 2009 -0800

    Fix more leaks of pads and elements in gstplaysink.

    Don't keep extra references to volume and mute elements; we don't need
    to do so.
    Ensure we unref pads that we have references to, and release request
    pads.

commit c34f4441747bfe9bbf7abbfd6c821b1b17f2a070
Author: Michael Smith <msmith at songbirdnest.com>
Date:   Fri Jan 30 11:04:37 2009 -0800

    Avoid leaking all playsinks. Fix some internal leaks.

    Playsink was holding references to itself. Don't do that, it's not cool.
    Also, free all chains in dispose.

commit 906502b9bba200697173da369acac45aaa2e0e75
Author: Michael Smith <msmith at songbirdnest.com>
Date:   Fri Jan 30 10:54:12 2009 -0800

    Unref peer request pad after releasing it, since we hold a reference.

commit af8d3c51f08ebd9d7d30bbdfcdf6bedf1d046ec3
Author: Michael Smith <msmith at songbirdnest.com>
Date:   Fri Jan 30 10:52:52 2009 -0800

    Fix caps leak in playbin2.

commit ef1fa84575b06db3b079c5955efc57ac0a4a583b
Author: Michael Smith <msmith at songbirdnest.com>
Date:   Fri Jan 30 10:51:11 2009 -0800

    Unref active pad from selector when finding active stream.

commit f7abf8ed943949de4f012626967b94f07fe5e893
Author: Michael Smith <msmith at songbirdnest.com>
Date:   Fri Jan 30 10:49:55 2009 -0800

    Free uris when finalizing playbin2 instance.

commit a2b0229058c86c008f5918706e69f5a44d65474e
Author: Michael Smith <msmith at songbirdnest.com>
Date:   Fri Jan 30 10:38:17 2009 -0800

    Unref pads when iterating over them in analyse_source.

    Fixes leak of source's srcpad when using uridecodebin.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=569682.