[gstreamer-bugs] [Bug 587561] New: gst_byte_reader_masked_scan_uint32 improvement

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=587561

  GStreamer | gstreamer (core) | Ver: git
           Summary: gst_byte_reader_masked_scan_uint32 improvement
           Product: GStreamer
           Version: git
          Platform: Other
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gstreamer (core)
        AssignedTo: gstreamer-bugs at lists.sourceforge.net
        ReportedBy: ca.ingmarsson at gmail.com
         QAContact: gstreamer-bugs at lists.sourceforge.net
     GNOME version: Unspecified
   GNOME milestone: Unspecified


I think it makes sense if gst_byte_reader_masked_scan_uint32 always returns the
offset from the beginning of the data. I've attached a patch that does this.
I've also tried to clarify the documentation for the offset parameter.

I've also noticed that the examples in the documentation have the mask and
pattern parameters switched. I don't know if the function or the documentation
should be fixed.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=587561.