[gstreamer-bugs] [Bug 587799] New: h264parse not chopping the correct timestamp

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=587799

  GStreamer | gst-plugins-bad | Ver: git
           Summary: h264parse not chopping the correct timestamp
           Product: GStreamer
           Version: git
          Platform: Other
        OS/Version: All
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-plugins-bad
        AssignedTo: gstreamer-bugs at lists.sourceforge.net
        ReportedBy: oxcsnicho at gmail.com
         QAContact: gstreamer-bugs at lists.sourceforge.net
     GNOME version: Unversioned Enhancement
   GNOME milestone: Unspecified


Please describe the problem:
When the upstream element is a filesrc, h264parse is not putting the correct
timestamp in the buffer it pushes out.

Steps to reproduce:
When trying to mux an h264 video stream with an AAC audio stream within a MPEG2
TS container, I use the following pipeline:

gst-launch --gst-debug=h264parse:4 \
filesrc location=test.264 ! h264parse ! mux.
filesrc location=test.aac ! aacparse ! mux.
mpegtsmux name=mux ! filesink location=output.ts > test.ts.log 2>&1

And inspect the log file test.ts.log


Actual results:
By inspecting the debug output file test.ts.log, I saw that h264parse is
outputting timestamp 99:99.99.999 on every buffer it pushes out. An example
line in the log file

0:00:03.384807000 38630   0x662740 DEBUG              h264parse
gsth264parse.c:543:gst_h264_parse_chain_forward:<h264parse0> pushing buffer
0x5f8388, size 3878, ts 99:99:99.999999999

Expected results:
I think h264parse should be able to read into the NAL's a bit to put the
correct timestamp.

Does this happen every time?
yes

Other information:
I also looked into the source code of h264pares. It looks that it is not doing
anything to the timestamp at all, as it's merely passing the original timestamp
on the incoming buffer directly to the new buffer. Not sure if this is the
desired behavior... but I think the parser should be able to detect if the
timestamp is something like GST_CLOCK_TIME_NONE and upon this case put
something more meaningful to the timestamp field.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=587799.