[gstreamer-bugs] [Bug 588472] New: [basetransform] problems in reverse-negotiating

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=588472

  GStreamer | gstreamer (core) | Ver: git
           Summary: [basetransform] problems in reverse-negotiating
           Product: GStreamer
           Version: git
          Platform: Other
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gstreamer (core)
        AssignedTo: gstreamer-bugs at lists.sourceforge.net
        ReportedBy: thijsvermeir at gmail.com
         QAContact: gstreamer-bugs at lists.sourceforge.net
     GNOME version: Unspecified
   GNOME milestone: Unspecified


Hello,

Some time ago I made a commit [1] to fix a reverse-negotiating problem in
basetransform. But this was reverted by wim [2] because it shows some
flickering in test-scale.

But I believe this behaviour in the test-scale is correct as it is always
trying to reverse-negotiate the caps, and now it just wrongly negotiate it.
(can be seen from the logs)

The current implementation is wrong because now the original requested caps are
compared with the transformation of the suggested caps to decide to use proxy
in the basetransform element. But as we will return a buffer of the suggested
caps this comparison does not make sense anymore and the basetransform can do a
proxy where it should not.

[1]
http://cgit.freedesktop.org/gstreamer/gstreamer/commit/?id=50afd459579191772f42d1a44f3959e530c5c269
[2]
http://cgit.freedesktop.org/gstreamer/gstreamer/commit/?id=c786c5224ac8987f7f0413991b03dc1ab240c04f


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=588472.