[gstreamer-bugs] [Bug 584890] AMR plugins based on Opencore codecs

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=584890

  GStreamer | gst-plugins-ugly | Ver: git




------- Comment #14 from Iago  2009-07-15 05:35 UTC -------
Few comments on the patches to ease the review work:

- Removed amrnb plugin from -ugly (ext), which contained:
  amrnbenc
  amrnbdec
  amrnparse
- Removed armwb pluign from -bad (ext), which contained:
  amrwbenc
  amrwbdec
  amrwparse
- Added amr plugin in -ugly (gst), which contains:
  amrnbenc
  amrnbdec
  amrnbparse
  amrwbdec,
  amrwbparse
  (*) No amrwbenc, since opencore does not implement the encoder.
  (*) This plugin contains the opencore amr codecs, this is why I put it in gst
and not in ext.
  (*) I joined together the amr-nb and amr-wb stuff in a single amr plugin
because they are both based on the same code from opencore, but maybe you
prefer having both separated...
- Moved documentation related to amr-nb and amr-wb from -bad to -ugly (and
adapted it appropriately)
- Adapted unit tests

Hopefully I did not miss anything :). If you find something wrong let me know
and I'll fix it.

Also, while preparing the patch I found an amrparse plugin in -bad (gst). At
first glance it looks like this plugin implements the same stuff as the
amrnbparse and amrwbparse elements, I do not know if there is a good reason to
have these three elements or if it is just duplicated code.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=584890.