[gstreamer-bugs] [Bug 584838] basesrc: confusing QUERY_SEEKING handling

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=584838

  GStreamer | gstreamer (core) | Ver: git

Tim-Philipp Müller changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138927|accepted-commit_now         |committed
               Flag|                            |
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED




------- Comment #17 from Tim-Philipp Müller  2009-07-24 10:58 UTC -------
commit 527da05476e6d72ba04d1f11fe55eb797d88dc0d
Author: Robin Stocker <robin at nibor.org>
Date:   Fri Jul 24 09:50:19 2009 +0100

    basesrc: don't handle SEEKING queries for formats that don't match the one
the source operates in

    Return FALSE in basesrc's default query handler when we get a SEEKING query
for
    a format that's not the one the source operates in. Previously (ie. before,
in
    the git version) we would return TRUE in that case and seekable=FALSE,
which
    is more correct, but causes backwards compatibility problems. (Before that
    we would change the format of the query when answering, which was
completely
    broken since callers don't expect that or check for it). Since the SEEKING
    query is a fairly recent addition, not all demuxers, parsers and decoders
    implement it yet, in which case any SEEKING query by an application will
    just be passed upstream where it will then be handled by basesrc. Now, if
    e.g. totem does a SEEKING query for TIME format and we have a demuxer that
    doesn't implement the query, basesrc would answer it with seekable=FALSE in
    most cases, and totem can only take that as authoritative answer, not
knowing
    that the demuxer doesn't implement the SEEKING query. To avoid this, we
make
    basesrc return FALSE to SEEKING queries in unhandled formats. That way
    applications like totem can fall back on assuming seekability depending on
    whether a duration is available, or somesuch. Downstream elements doing
    such queries are likely to equate an unhandled query with a non-seekable
    response as well, so this should be an acceptable fix for the time being.

    See #584838, #588944, #589423 and #589424.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=584838.