[gstreamer-bugs] [Bug 590056] [collectpads] race resulting in double flush-stop being outputted

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=590056

  GStreamer | gstreamer (core) | Ver: git

Edward Hervey changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #139415|accepted-commit_now         |committed
               Flag|                            |
 Attachment #139416|accepted-commit_now         |committed
               Flag|                            |
 Attachment #139417|accepted-commit_now         |committed
               Flag|                            |
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|HEAD                        |0.10.24




------- Comment #5 from Edward Hervey  2009-07-29 09:51 UTC -------
commit cfb22080e28236802018868e4f40d46b57560c39
Author: Edward Hervey <bilboed at bilboed.com>
Date:   Tue Jul 28 21:15:52 2009 +0200

    collectpads: Get the flushing state with the object lock taken.

    Fixes #590056

commit c138aa8648567f95331a8497dc82cb5e567dc017
Author: Edward Hervey <bilboed at bilboed.com>
Date:   Tue Jul 28 21:14:11 2009 +0200

    collectpads: Make sure the CollectData list is up-to-date when
reading/setting it

    Without this, we risked:
    * Checking the flushing state on an unexisting list
    * Not setting the flushing state on pads that had just been added

    Partially fixes #590056

commit fcbba9b15a79487cdde9b6db35693783bfd5aae3
Author: Edward Hervey <bilboed at bilboed.com>
Date:   Tue Jul 28 21:12:25 2009 +0200

    collectpads: Split out _check_pads into a version without lock taking.

    This is so we can use _check_pads in places where we've already taken
    the lock in question.

    Partially fixes #590056


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=590056.