[gstreamer-bugs] [Bug 590172] New: ffdec_theora does not work

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=590172

  GStreamer | gst-ffmpeg | Ver: git
           Summary: ffdec_theora does not work
           Product: GStreamer
           Version: git
          Platform: Other
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-ffmpeg
        AssignedTo: gstreamer-bugs at lists.sourceforge.net
        ReportedBy: tester at tester.ca
         QAContact: gstreamer-bugs at lists.sourceforge.net
     GNOME version: Unspecified
   GNOME milestone: Unspecified


"videotestsrc ! theoraenc ! ffdec_theora ! xvimagesink" fails.
"videotestsrc ! theoraenc ! rtptheorapay ! rtptheoradepay ! ffdec_theora !
xvimagesink" fails too.

This tries to use the internal theora decoder of ffmpeg (not libtheora). 

Thats probably a problem with gst-ffmpeg... Anyway, I suggest just disabling
the ffmpeg implementation and going with the libtheora implementation for now.

Proposed patch:

diff --git a/ext/ffmpeg/gstffmpegdec.c b/ext/ffmpeg/gstffmpegdec.c
index 6eb0903..35c2330 100644
--- a/ext/ffmpeg/gstffmpegdec.c
+++ b/ext/ffmpeg/gstffmpegdec.c
@@ -2747,6 +2747,7 @@ gst_ffmpegdec_register (GstPlugin * plugin)
     /* MPEG1VIDEO : the mpeg2video decoder is preferred */
     /* MP1 : Use MP3 for decoding */
     /* MP2 : Use MP3 for decoding */
+    /* Theora: Use libtheora based theoradec */
     if (!strcmp (in_plugin->name, "gif") ||
         !strcmp (in_plugin->name, "vorbis") ||
         !strcmp (in_plugin->name, "mpeg1video") ||
@@ -2754,6 +2755,7 @@ gst_ffmpegdec_register (GstPlugin * plugin)
         !strcmp (in_plugin->name, "mp1") ||
         !strcmp (in_plugin->name, "mp2") ||
         !strcmp (in_plugin->name, "libfaad") ||
+        !strcmp (in_plugin->name, "theora") ||
         !strcmp (in_plugin->name, "mpeg4aac")) {
       GST_LOG ("Ignoring decoder %s", in_plugin->name);
       goto next;


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=590172.