[gstreamer-bugs] [Bug 578278] gst-ffmpeg: assign offsets (from upstream) to outgoing buffers

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=578278

  GStreamer | gst-ffmpeg | Ver: git

Sebastian Dröge changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #139483|none                        |needs-work
               Flag|                            |
             Status|RESOLVED                    |UNCONFIRMED
         Resolution|FIXED                       |




------- Comment #9 from Sebastian Dröge  2009-07-30 10:57 UTC -------
Some comments:
- Please choose a better name than GstOpaque. That name tells nothing :)
- Use GSLice for allocating the GstOpaque objects, that will be faster and
result in less memory fragmentation
- g_list_append() is slow (always needs to go to the end of the list), better
use _prepend() if possible
- Use GPOINTER_TO_SIZE(), _TO_UINT() will be 32 bit... and you will see crashes
on 64 bit architectures :)

Other than that this looks as optimal as it can get


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=578278.