[gstreamer-bugs] [Bug 584455] New: flacenc sometimes writes broken flac files

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=584455

  GStreamer | gst-plugins-good | Ver: git
           Summary: flacenc sometimes writes broken flac files
           Product: GStreamer
           Version: git
          Platform: Other
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: Normal
         Component: gst-plugins-good
        AssignedTo: gstreamer-bugs at lists.sourceforge.net
        ReportedBy: thomas at apestaart.org
         QAContact: gstreamer-bugs at lists.sourceforge.net
     GNOME version: Unspecified
   GNOME milestone: Unspecified


I've been able to consistently reproduce this on master (0.10.15.1) with:

gst-launch -v filesrc location=/home/thomas/gst/media/medium/sugar.ogg !
oggdemux ! vorbisdec ! audioconvert ! audio/x-raw-int,width=16,depth=16 !
flacenc ! filesink location=test.flac; flac -d test.flac -f

The output from flac -d is:

test.flac: ERROR: bits per sample is 32, must be 4-24


Tim has been able to reproduce this, but only using filesrc; when he tried with
httpsrc it didn't work.

After bisecting, I found the following patch responsible:

df707c666433a78d3878af6f055698d5756226c4 is first bad commit
commit df707c666433a78d3878af6f055698d5756226c4
Author: Sebastian Dröge <slomo at circular-chaos.org>
Date:   Sun Aug 3 12:23:49 2008 +0000

    ext/flac/gstflacenc.c: Set an estimate for the total number of samples that
will be encoded if possible to help decod...

    Original commit message from CVS:
    * ext/flac/gstflacenc.c: (gst_flac_enc_query_peer_total_samples),
    (gst_flac_enc_sink_setcaps), (gst_flac_enc_write_callback):
    Set an estimate for the total number of samples that will be encoded
    if possible to help decoders if the streaminfo can't be rewritten
    later (like when muxing into Ogg containers).
    Add a warning if we get header packets after data packets as those
    will get lost when muxing into Ogg, i.e. rewriting the headers doesn't
    work.

:100644 100644 cc564bd510602fb58d99c05a304b3ca588385821
890ca15411e027cdac7f026cce6b4762ca7ad806 M      ChangeLog
:040000 040000 6e346457b1c979c4f3b2dcc72bf4e7eba84415f2
20d0a1ec8792223b02d31c1ebf6e3d8b4b4f47d5 M      ext


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=584455.