[gstreamer-bugs] [Bug 584252] enhancements to OSSv4 plugin

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=584252

  GStreamer | gst-plugins-bad | Ver: 0.10.x

Brian Cameron changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEEDINFO                    |UNCONFIRMED




------- Comment #6 from Brian Cameron  2009-06-09 20:09 UTC -------

I just talked with Garrett on the phone, and have some feedback about the two
outstanding issues.

Tim-Phillipp: Garret agreed that keeping the poll interval at 500ms is 
acceptable.

Jan: if you look at the oss4-mixer.c code, in the
gst_oss4_mixer_control_get_translated_name function you will notice that the
num variable is only used in a call to g_snprintf call that looks like this:

   g_snprintf(name, sizeof (name), fmtbuf, _(labels[i].label), num);

Note that fmtbuf by default is "%s", so the num argument is ignored in this
case.  However when the code falls into the previous if-case where num is set, 
then fmtbuf is also changed to "%s %n".  So, in other words, the num variable
in the g_snprintf call is only used if it falls into the if-block where num is
set to a value.

To make the compiler happier, and avoid the warning, it would be okay to just
initialize it to -1 at the beginning of the function.

Jan, can you go ahead and make these two minor changes (reset the poll back to
500ms and initialize the num variable to -1) before you commit?  Or would you
like me to regenerate the patch with these two changes?

Thanks,

Brian


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=584252.