[gstreamer-bugs] [Bug 585956] [mp3parse] indexing improvements

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=585956

  GStreamer | gst-plugins-ugly | Ver: git

Tim-Philipp Müller changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136703|accepted-commit_after_freeze|committed
               Flag|                            |
 Attachment #136704|accepted-commit_after_freeze|committed
               Flag|                            |
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|HEAD                        |0.10.13




------- Comment #4 from Tim-Philipp Müller  2009-06-22 09:48 UTC -------
> I think you're leaking the seeking query here

Fixed, thanks.


 commit af3ab2ae945325976cb247e819a348850b81cd8f
 Author: Tim-Philipp Müller <tim.muller at collabora.co.uk>
 Date:   Tue Jun 16 09:45:59 2009 +0100

    mp3parse: don't put every single frame into the index

    Let's not put every single mp3 frame in our index, a few frames per
    second should be more than enough. For now use an index interval
    of 100ms-500ms depending on the upstream size, to keep the index at
    a reasonable size. Factor out the code that adds the index entry
    into a separate function for better code readability.


 commit 1db592839e1cb07fca7bbd3f2878e76bfb154ac2
 Author: Tim-Philipp Müller <tim.muller at collabora.co.uk>
 Date:   Tue Jun 16 01:40:42 2009 +0100

    mp3parse: assume seekability only if we know the upstream size

    While technically upstream may be seekable even if it doesn't know
    the exact size, I can't think of a use case where this distincation
    is relevant in practice, so for now just assume we're not seekable
    if upstream doesn't provide us with a size. Makes sure we don't
    build a seek index when streaming internet radio with sources that
    pretend to be seekable until you try to actually seek.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=585956.