[gstreamer-bugs] [Bug 586566] Add GAP Flag support to gstcapsfilter

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=586566

  GStreamer | gstreamer (core) | Ver: git




------- Comment #5 from Sebastian Dröge  2009-06-22 17:44 UTC -------
(In reply to comment #4)
> I am confused.  According to 
> 
> http://gstreamer.freedesktop.org/data/doc/gstreamer/head/gstreamer-libs/html/GstBaseTransform.html#gst-base-transform-set-gap-aware
> 
> anything that subclasses GSTBaseTransform and does not use the method
> 
> gst_base_transform_set_gap_aware ()
> 
> will have its GAP Flag unset.  gstcapsfilter is a case of this.  Therefore a
> pipeline that has otherwise GAP aware elements cannot use gstcapsfilter and
> preserve GAPs throughout the pipeline.  What is the harm in this patch?  How
> does it interfere with other elements?  (I am not advocating changing
> GSTBaseTransform)
> Have I misunderstood something?  Sorry if I have.

No, your understanding is correct. I'll commit your patch tomorrow, don't worry
:)


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=586566.