[gstreamer-bugs] [Bug 573623] [API] Array binary search utility function

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=573623

  GStreamer | gstreamer (core) | Ver: git

Tim-Philipp Müller changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |t.i.m at zen.co.uk




------- Comment #3 from Tim-Philipp Müller  2009-03-01 19:13 UTC -------
Looks useful. Some nitpicks (feel free to ignore any or all):

 - GstSearchMode docs say "The different types of URI direction."
   (and should have a Since: tag)

 - gst_search_mode_get_type() should be g_type_class_ref()'ed in
   init_post() in gst/gst.c

 - naming: I think it'd be nice to avoid abbreviations like
   'binsearch' (there's no chance in hell anyone is going to
   fit a call into one line of code anyway, so we may just
   as well spell it out, no?)

 - "total_elements" => "num_elements"?

 - "size" => "element_size" ?

 - "GCompareDataFunc search_func" - is a GCompareDataFunc
   really the most appropriate, or shouldn't we rather
   define our own? (GCompareDataFunc implies that search_data
   is of the same type as array elements, doesn't it? Might
   be confusing ...)

 - docs: "comparision" => comparison


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=573623.