[gstreamer-bugs] [Bug 574163] New: Fix gst_pad_activate_pull deactivation with unlinked element

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=574163

  GStreamer | gstreamer (core) | Ver: git
           Summary: Fix gst_pad_activate_pull deactivation with unlinked
                    element
           Product: GStreamer
           Version: git
          Platform: Other
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gstreamer (core)
        AssignedTo: gstreamer-bugs at lists.sourceforge.net
        ReportedBy: hexa00 at gmail.com
         QAContact: gstreamer-bugs at lists.sourceforge.net
     GNOME version: Unspecified
   GNOME milestone: Unspecified


When de/activating a pad in pull mode the pad needs to de/activate the
peer pad it is connected to, failure to be able to do this in activation mode
is an error.

However failure to do it in deactivation mode is not an error imho as long as
something else deactivates that pad which is very likely, and even if nothing
does I'm don't think it's worth making the deactivation of the pull element
fail.

In my situation as I unlinked an element in the PAUSED state (without any
dataflow), before setting it's state to NULL, the pad thread leaked since it
could not deactivate it's pad as it was unlinked. ( I know that's not the best
senario but it shouldn't cause a leak...)

Fixed code to make only the activation case an error.

please review /comment...,


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=574163.