[gstreamer-bugs] [Bug 574241] New: gst_tag_list_add and gst_tag_list_add_values behave inconsistently for GST_TAG_MERGE_REPLACE_ALL

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=574241

  GStreamer | gstreamer (core) | Ver: 0.10.22
           Summary: gst_tag_list_add and gst_tag_list_add_values behave
                    inconsistently for GST_TAG_MERGE_REPLACE_ALL
           Product: GStreamer
           Version: 0.10.22
          Platform: Other
        OS/Version: All
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gstreamer (core)
        AssignedTo: gstreamer-bugs at lists.sourceforge.net
        ReportedBy: roderich.schupp at googlemail.com
         QAContact: gstreamer-bugs at lists.sourceforge.net
     GNOME version: Unspecified
   GNOME milestone: Unspecified


gst_tag_list_add and gst_tag_list_add_values (and their
*_valist variants) behave inconsistently when the
merge mode is GST_TAG_MERGE_REPLACE_ALL:

gst_tag_list_add clears the _whole_ tag list (and not
just the tags I'm trying to add) before adding 
the new tags. OTOH gst_tag_list_add_values doesn't
affect tags already present on tga list that 
are different from the tags I'm trying to add.

IMHO gst_tag_list_add gets it right according to the 
documentation about GST_TAG_MERGE_REPLACE_ALL. 

The difference between the two functions are these lines
at the start of gst_tag_list_add_valist:

  if (mode == GST_TAG_MERGE_REPLACE_ALL) {
    gst_structure_remove_all_fields (list);
  }


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=574241.