[gstreamer-bugs] [Bug 572863] [32bit] ffdec_nellymoser seg faults (misaligned data)

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=572863

  GStreamer | gst-ffmpeg | Ver: git




------- Comment #10 from Tim-Philipp Müller  2009-03-06 14:43 UTC -------
(From update of attachment 130186)
>-  /* outgoing buffer */
>-  *outbuf = gst_buffer_new_and_alloc (AVCODEC_MAX_AUDIO_FRAME_SIZE);

Oh wow, I would have assumed g_malloc() provides a reasonably aligned return
value. Maybe we should fix gst_buffer_new_and_alloc() to do this automatically?
Or provide new functions for that? (Both doesn't help us now of course)

>+  /* outgoing buffer. We use av_malloc() to have properly aligned memory. */
>+  *outbuf = gst_buffer_new ();
>+  GST_BUFFER_DATA (*outbuf) = GST_BUFFER_MALLOCDATA (*outbuf) = av_malloc(AVCODEC_MAX_AUDIO_FRAME_SIZE);
>+  GST_BUFFER_SIZE (*outbuf) = AVCODEC_MAX_AUDIO_FRAME_SIZE;

Don't we also need an GST_BUFFER_FREE_FUNC (*outbuf) = av_free; ?

What about the input buffer? Not sure how to read the docs, but it seems like
the input buffer needs to be at least 4-byte aligned?


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=572863.