[gstreamer-bugs] [Bug 516031] flac within ogg container can't be played on Jokosher

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=516031

  GStreamer | gst-plugins-base | Ver: git




------- Comment #6 from Laszlo Pandy  2009-03-07 17:09 UTC -------
Created an attachment (id=130240)
 --> (http://bugzilla.gnome.org/attachment.cgi?id=130240&action=view)
In the event handler, check if we have initialized the stream before using it.

I can confirm this on latest git. The problem does not appear with playbin
because there are no flush or EOS events sent to the flacdec until the data
starts flowing. However gnonlin does flushing seeks before the audio starts
playing because gnonlin often does not start at the beginning of the file.

In the event handler, gst_flac_dec_sink_event(), two functions are called on
the FLAC stream without checking if it has been initialized:
FLAC__stream_decoder_flush()
FLAC__stream_decoder_process_until_end_of_stream()

Both these FLAC__*() functions modify the internal state of the FLAC stream.
Later, when the buffers start flowing, gst_flac_dec_chain() tries to initialize
the stream. the FLAC__stream_decoder_init_stream() call will fail because the
previous calls to FLAC__*() changed the stream state so it is no longer in the
initialized state.

FLAC__stream_decoder_init_stream() fails with code
FLAC__STREAM_DECODER_INIT_STATUS_ALREADY_INITIALIZED.

My patch simply checks if we have initialized the stream in
gst_flac_dec_sink_event(), and if we haven't, skip over any calls to FLAC__*().


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=516031.