[gstreamer-bugs] [Bug 516031] flac within ogg container can't be played on Jokosher

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=516031

  GStreamer | gst-plugins-good | Ver: git

Edward Hervey changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #130240|accepted-commit_now         |committed
               Flag|                            |
             Status|NEW                         |RESOLVED
          Component|gst-plugins-base            |gst-plugins-good
         Resolution|                            |FIXED
   Target Milestone|HEAD                        |0.10.15




------- Comment #8 from Edward Hervey  2009-03-12 15:16 UTC -------
commit 73fac6e4ea5df98afc5a04cc267b0a89b1b10ad4
Author: Laszlo Pandy <laszlok2 at gmail.com>
Date:   Thu Mar 12 16:10:25 2009 +0100

    Don't call FLAC__ methods before it's initialized. Fixes #516031

    In the event handler, gst_flac_dec_sink_event(), two functions are called
on
    the FLAC stream without checking if it has been initialized:
    FLAC__stream_decoder_flush()
    FLAC__stream_decoder_process_until_end_of_stream()

    Both these FLAC__*() functions modify the internal state of the FLAC
stream.
    Later, when the buffers start flowing, gst_flac_dec_chain() tries to
initialize
    the stream. the FLAC__stream_decoder_init_stream() call will fail because
the
    previous calls to FLAC__*() changed the stream state so it is no longer in
the
    initialized state.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=516031.