[gstreamer-bugs] [Bug 575672] New: [mpegtsdemux] crashes when souphttpsrc is used as a stream source

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=575672

  GStreamer | gst-plugins-bad | Ver: 0.10.10
           Summary: [mpegtsdemux] crashes when souphttpsrc is used as a
                    stream source
           Product: GStreamer
           Version: 0.10.10
          Platform: Other
        OS/Version: FreeBSD
            Status: UNCONFIRMED
          Severity: major
          Priority: Normal
         Component: gst-plugins-bad
        AssignedTo: gstreamer-bugs at lists.sourceforge.net
        ReportedBy: ulin at tut.by
         QAContact: gstreamer-bugs at lists.sourceforge.net
     GNOME version: Unspecified
   GNOME milestone: Unspecified


The crash is very hard to reproduce. We've managed to reproduce it on one
sample TS file only. Problem occurs here:

gstmpegtsdemux.c, line 1610:

if (demux->streams[demux->streams[j]->PMT_pid] &&
    stream->PID ==
    demux->streams[demux->streams[j]->PMT_pid]->PMT.PCR_PID) {

'demux->streams[j]->PMT_pid' is 0x2000 here (FLUTS_MAX_PID + 1)

Several lines before there's a check for PMT_pid validity, but it looks really
strange:

if (demux->streams[j] && demux->streams[j]->PMT_pid)

As I understand there should be something like this:

if (demux->streams[j] && demux->streams[j]->PMT_pid <= FLUTS_MAX_PID)

as PMT_pid can't be 0 (reserved for PAT pid)


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=575672.