[gstreamer-bugs] [Bug 543591] Gnonlin can not play theora streams

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=543591

  GStreamer | gst-plugins-base | Ver: git

Edward Hervey changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bilboed at gmail.com
 Attachment #131110|none                        |committed
               Flag|                            |
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|HEAD                        |0.10.23




------- Comment #5 from Edward Hervey  2009-03-23 10:43 UTC -------
commit b7fdb7c6d71b7185ac54b94d7182219a51316210
Author: Edward Hervey <bilboed at bilboed.com>
Date:   Mon Mar 23 11:38:53 2009 +0100

    theoradec: Use GST_CLOCK_TIME_NONE for invalid positions. Fixes #543591

    The problem was that previously we didn't check whether
_theora_granule_frame
    returned a negative framecount or not, resulting in bogus timestamps.

diff --git a/ext/theora/theoradec.c b/ext/theora/theoradec.c
index d9d8fcd..60e2ef2 100644
--- a/ext/theora/theoradec.c
+++ b/ext/theora/theoradec.c
@@ -249,10 +249,11 @@ _theora_granule_start_time (GstTheoraDec * dec, gint64
granulepos)

   /* invalid granule results in invalid time */
   if (granulepos == -1)
-    return -1;
+    return GST_CLOCK_TIME_NONE;

   /* get framecount */
-  framecount = _theora_granule_frame (dec, granulepos);
+  if ((framecount = _theora_granule_frame (dec, granulepos)) < 0)
+    return GST_CLOCK_TIME_NONE;

   return gst_util_uint64_scale_int (framecount * GST_SECOND,
       dec->info.fps_denominator, dec->info.fps_numerator);


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=543591.