[gstreamer-bugs] [Bug 574805] [capsfilter] Doesn't reset the internal suggestion with ANY or NULL caps

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=574805

  GStreamer | gstreamer (core) | Ver: git

Edward Hervey changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #130424|none                        |committed
               Flag|                            |
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|HEAD                        |0.10.23




------- Comment #2 from Edward Hervey  2009-03-31 13:11 UTC -------
commit ca662eb57a64b9d74448f523ecca64ef83fa627b
Author: Edward Hervey <bilboed at bilboed.com>
Date:   Thu Mar 26 17:25:08 2009 +0100

    capsfilter. Always calls _suggest, even with NULL caps. Fixes #574805

diff --git a/plugins/elements/gstcapsfilter.c
b/plugins/elements/gstcapsfilter.c
index afa1ff5..3442ff3 100644
--- a/plugins/elements/gstcapsfilter.c
+++ b/plugins/elements/gstcapsfilter.c
@@ -200,12 +200,12 @@ gst_capsfilter_set_property (GObject * object, guint
prop_id,
       }
       GST_OBJECT_UNLOCK (GST_BASE_TRANSFORM_SINK_PAD (object));

-      if (suggest) {
-        GST_DEBUG_OBJECT (capsfilter, "suggest new caps %" GST_PTR_FORMAT,
-            suggest);
-        gst_base_transform_suggest (GST_BASE_TRANSFORM (object), suggest, 0);
+      GST_DEBUG_OBJECT (capsfilter, "suggesting new caps %" GST_PTR_FORMAT,
+          suggest);
+      gst_base_transform_suggest (GST_BASE_TRANSFORM (object), suggest, 0);
+      if (suggest)
         gst_caps_unref (suggest);
-      }
+
       break;
     }
     default:


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=574805.