[gstreamer-bugs] [Bug 581375] New: rtpssrcdemux crashes on SR-less rtcp packets

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=581375

  GStreamer | gst-plugins-bad | Ver: git
           Summary: rtpssrcdemux crashes on SR-less rtcp packets
           Product: GStreamer
           Version: git
          Platform: Other
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-plugins-bad
        AssignedTo: gstreamer-bugs at lists.sourceforge.net
        ReportedBy: tester at tester.ca
         QAContact: gstreamer-bugs at lists.sourceforge.net
                CC: sjoerd at luon.net
     GNOME version: Unspecified
   GNOME milestone: Unspecified


Sjoerd found this bug while doing some interop testing. RTCP compound packets
don't always start with a SR packet, they could also only contain RR packets. I
guess in that case it is not useful for syncing so we can just drop it.

Patch:

--- a/gst/rtpmanager/gstrtpssrcdemux.c
+++ b/gst/rtpmanager/gstrtpssrcdemux.c
@@ -482,6 +482,9 @@ gst_rtp_ssrc_demux_rtcp_chain (GstPad * pad, GstBuffer *
buf)
       gst_rtcp_packet_sr_get_sender_info (&packet, &ssrc, NULL, NULL, NULL,
           NULL);
       break;
+    case GST_RTCP_TYPE_RR:
+      gst_buffer_unref (buf);
+      return GST_FLOW_OK;
     default:
       goto invalid_rtcp;
   }


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=581375.