[gstreamer-bugs] [Bug 582252] rganalysis test broken by recent commit

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=582252

  GStreamer | gst-plugins-good | Ver: git




------- Comment #6 from Sebastian Dröge  2009-05-12 18:30 UTC -------
(In reply to comment #5)
> The element was implementing GAP flag support, which Sebastian removed in a
> previous commit for no good reason.

I wouldn't say for no good reason. If you don't perform all the analyzing steps
on GAP buffers too you won't get correct values as the analysis takes buffer
content before the GAP buffers into account too but you know that ;)
Ignoring the GAP buffers doesn't change the overall result of the analysis but
changes the per-window results that are posted as messages.

What could be done to still simply ignore GAP buffers, but only if no messages
are posted... and limit the message property to be changed in states < PAUSED.

Does this sounds good to you? Or am I missing something? (Of course for the
filters, etc one can implement "silence" versions that don't take the input
into account but I don't think that makes much difference)

> The unit test is correct, tests can make use of element implementation details
> like this. The only way to verify that the element actually discards GAP
> buffers is to feed it non-silence GAP buffers, thus uncovering hidden
> processing that is supposed to be skipped.

Agreed, I should've run the unit test before committing and should've mentioned
this in the commit message.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=582252.