[gstreamer-bugs] [Bug 582942] crash in libvorbis when parsing some ogg files

GStreamer (bugzilla.gnome.org) bugzilla-daemon at bugzilla.gnome.org
Thu May 21 00:46:30 PDT 2009


If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=582942

  GStreamer | gst-plugins-base | Ver: 0.10.x

Alex Bennee changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEEDINFO                    |NEW




------- Comment #17 from Alex Bennee  2009-05-21 07:46 UTC -------
Well in my case vorbis_synthesis_init is failing and therefore vorbis cannot
continue until it is correctly initialised. I don't think this is a guaranteed
success operation so shouldn't GStreamer pay attention to the return values? 

diff --git a/ext/vorbis/vorbisdec.c b/ext/vorbis/vorbisdec.c
index 6b3f725..a890f66 100644
--- a/ext/vorbis/vorbisdec.c
+++ b/ext/vorbis/vorbisdec.c
@@ -761,10 +761,21 @@ static GstFlowReturn
 vorbis_handle_type_packet (GstVorbisDec * vd)
 {
   GList *walk;
+  int r;

   g_assert (vd->initialized == FALSE);

-  vorbis_synthesis_init (&vd->vd, &vd->vi);
+  fprintf(stderr,"vorbis_handle_type_packet: vd=%p\n", vd);
+  
+  r = vorbis_synthesis_init (&vd->vd, &vd->vi);
+
+  if (r)
+  {
+      fprintf(stderr,"  failed init %d\n",r);
+      fprintf(stderr,"  vd->vd=%p, vd->vi=%p\n", vd->vd, vd->vi);
+      return GST_FLOW_WRONG_STATE;
+  }
+

I don't know what the correct GStreamer return should be but I guessed at
GST_FLOW_WRONG_STATE, but certainly for this packet no decode should be
attempted.  


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=582942.




More information about the Gstreamer-bugs mailing list