[gstreamer-bugs] [Bug 580214] Equalizer starts distorting the sound after a while.

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=580214

  GStreamer | gst-plugins-good | Ver: 0.10.22




------- Comment #21 from Sebastian Dröge  2009-05-23 08:05 UTC -------
(In reply to comment #20)
> Created an attachment (id=135215)
 --> (http://bugzilla.gnome.org/attachment.cgi?id=135215&action=view) [edit]
> Patch - Maintain precision as much as possible, move floor call to the last
> possible time to do so
> 
> This seems to fix the muddy sound for me by maintaining the precision of the
> history using doubles and moving the floor() call to the last possible moment
> (instead of doing it in the step() function).

Great, I'll do some tests later too and will commit it then... and work later
on the bandwidth issue mentioned above.

Using integer arithmetic for the int16 mode isn't a very good idea in general I
guess because IIR filters are usually very picky about rounding errors so the
patch is a good idea in any way :)


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=580214.